Update orderResponse of placeOrder for smartConnect.py#16
Open
pratikbhadane24 wants to merge 1 commit intoangel-one:mainfrom
Open
Update orderResponse of placeOrder for smartConnect.py#16pratikbhadane24 wants to merge 1 commit intoangel-one:mainfrom
pratikbhadane24 wants to merge 1 commit intoangel-one:mainfrom
Conversation
Enhanced user understanding: By incorporating the orderResponse return, users can now effectively discern whether their order placement was successful or not. The previous approach of only returning the orderId, which resulted in 'None' for failed placements, has been mitigated with this improvement. The resulting user experience is now significantly more informative and user-friendly.
Author
|
Anyone? |
gulshan178
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced user understanding:
By incorporating the orderResponse return, users can now effectively discern whether their order placement was successful or not. The previous approach of only returning the orderId, which resulted in 'None' for failed placements, has been mitigated with this improvement. The resulting user experience is now significantly more informative and user-friendly.