Closed
Conversation
Collaborator
|
Same as Issue #96. I need a test that shows that the global breaks something. |
Collaborator
|
But since it's pretty minor I add your change anyway. |
Well, here we go: https://github.com/facebook/react-native/pull/7899/files#diff-781111e0db5cf5c6cc9b56a63fdfcbf6R31 test breaks on this line. That's the source: https://github.com/facebook/react-native/blob/master/local-cli/rnpm/link/src/ios/addFileToProject.js |
Author
|
In general, I consider this as a type error... I can't think of any case where assigning to global context would be desirable (also - esp. that we overwrite that for every new PbxFile). BTW - we don't need it at all in that case actually, passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
jest(test runner) and react-native environment, the assignment is going to be ignored and theselfremains pointing to whatever react-native defined for the sake of testing. Adding missing var here.CC: @davidaurelio