Skip to content

factorial function#1

Open
shellybekhor wants to merge 1 commit intoalexger:masterfrom
shellybekhor:master
Open

factorial function#1
shellybekhor wants to merge 1 commit intoalexger:masterfrom
shellybekhor:master

Conversation

@shellybekhor
Copy link

No description provided.

Copy link
Owner

@alexger alexger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
Please see my comments

@@ -0,0 +1,16 @@
/**
* Created by Shelly Bekhor on 06-01-20.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe what this class does

* Created by Shelly Bekhor on 06-01-20.
*/
public class factorial {
static int factorial(int n){
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write javadoc

return 1;
}
else{
return factorial(n-1);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have a mistake here. You probably meant n * factorial(n-1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants