Ignore lost packets in the calculation of statistics#67
Open
handymenny wants to merge 1 commit intoalessandromaggio:masterfrom
Open
Ignore lost packets in the calculation of statistics#67handymenny wants to merge 1 commit intoalessandromaggio:masterfrom
handymenny wants to merge 1 commit intoalessandromaggio:masterfrom
Conversation
If all packets are lost all statistics will be 0
Owner
|
That is a good point, however it alters the behaviour of the application. We should make this way of computing stats optional if a flag is provided, and in a later breaking version switch it to the default approach. If @handymenny you could add that to your change we could integrate it in the next release. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some tests here: handymenny@a2ecdf2
Besides the fact that they're too messy, without #66 they will fail
If you don't completely agree with these changes you might as well make it optional, but I think 99% of users don't want TIMEOUT to be considered in the stats.
You might think of a special value when there is 100% packet loss, but in my opinion 0 is fine