Fix incorrect requirements.txt and latency calculations when old ping replies come in after new pings are sent.#118
Open
josiah-zx wants to merge 3 commits intoalessandromaggio:devfrom
Conversation
* fix(icmp.py): ICMP header format string All values in the struct should be unsigned. * pylint issues resolved Fixed a bunch of pylint issues * First Readme push headers updated. * Update README.md * Update README.md * UMLs created. * UMLs created. * Folder Structure Created. * backticks added. * Supporting words added. * Grammer fix * Code Styles section finished. * Fix made * Fix made * Readme fixed. * Readme fixed. * Ready for pull request. * Finally ready for pull request. * Testcase added, * feat: integrate alessandromaggio#89, alessandromaggio#92, and alessandromaggio#93 Allow count greater than 16-bit, fix pylint issues, update and expand readme Co-authored-by: David A. Bell <8835326+dabell-cc@users.noreply.github.com> Co-authored-by: Mark Mayo <mark@there.co.nz> Co-authored-by: Aleksa Zatezalo <aleksa@kali.azatezalo> Co-authored-by: Aleksa Zatezalo <59803757+AleksaZatezalo@users.noreply.github.com>
… replies overlap new sends
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #114 and fixes issue #116
#116: Updated requirements pexpect version to 4.8.0 rather than 4.0.8
#114: Fixed a bug in which the latency in ms would be calculated incorrectly where upon receiving a reply, the latency since last packet was sent (not necessarily the packet the reply is for) would be calculated and displayed.
Packet send times are now stored and retrieved per packet sequence number, meaning latency calculations will use them instead of whenever the most recent packet was sent out. This retains accurate measurements among poor network conditions where packets arrive out of order (like in #114) as well as the case where the delay between pings is shorter than the real-world latency (such as pinging a JP server from US, where ping is over 200ms and ping delay is only 200).
This is my first open source contribution, any feedback or changes are welcome.