MWPW-185638 update prompt urls parsing logic to support , as delimiter #672
+16
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[[MWPW-186708][Domain routing]Load error file from adobe.com on acrobat subdomain ](40d7d4f) [[MWPW-186857]Fix tab trap issue (](6d07562) [[MWPW-171479] fixing the grey-line issue (](10ae5a1) [[MWPW-186708][Domain routing]Load error file from adobe.com on acrobat subdomain (](cb66072) [[MWPW-185735]Load milo libs from adobe.com for acrobat.adobe.com domain (](41dda45) [[MWPW-182131] Automatic invalidating CDN cache (](6856ff8) [[MWPW-164353] Implementing dc-pdflite library to check file page count (Phase 1)(](95fb9b4) [[MWPW-164353] Updating pdflite libs path (](f5b354f) **Test URLs:** Before: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=main After: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=stage Before: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=main After: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=stage
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Ruchika4
requested changes
Feb 10, 2026
| .split('||').map((s) => s.trim()).filter((s) => s); | ||
| let urls = []; | ||
| if (typeof item.variationUrls === 'string' && item.variationUrls.trim()) { | ||
| const parts = item.variationUrls.split(',https'); |
Collaborator
There was a problem hiding this comment.
Hi @vipu0303 , as discussed can we split making sure if there is a space before or after comma code handles that too. May be something like below
const parts = item.variationUrls.split(/\s*,\s*https/);
Collaborator
Author
There was a problem hiding this comment.
updated to handle parsing of below string:
variationUrls: 'https://u1,https://u2, https://u3 , https://u4'
Ruchika4
approved these changes
Feb 11, 2026
sanjayms01
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the urls parsing logic to have , as delimiter instead of ||
The excel authoring and this PR merge to main should be done at same time so as to not break the experience on prod.
Resolves: MWPW-185638
Test URLs:
The before URL works now as the prompt excel has || as delimeter
The After URL will work once the the prompt excel is updated to have , as delimiter.