generated from adobecom/milo-college
-
Notifications
You must be signed in to change notification settings - Fork 11
[MWPW-183090] cgen authouring to avoid localization #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vipu0303
wants to merge
8
commits into
stage
Choose a base branch
from
MWPW-183090
base: stage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[[MWPW-186708][Domain routing]Load error file from adobe.com on acrobat subdomain ](40d7d4f) [[MWPW-186857]Fix tab trap issue (](6d07562) [[MWPW-171479] fixing the grey-line issue (](10ae5a1) [[MWPW-186708][Domain routing]Load error file from adobe.com on acrobat subdomain (](cb66072) [[MWPW-185735]Load milo libs from adobe.com for acrobat.adobe.com domain (](41dda45) [[MWPW-182131] Automatic invalidating CDN cache (](6856ff8) [[MWPW-164353] Implementing dc-pdflite library to check file page count (Phase 1)(](95fb9b4) [[MWPW-164353] Updating pdflite libs path (](f5b354f) **Test URLs:** Before: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=main After: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=stage Before: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=main After: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=stage
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
sanjayms01
requested changes
Feb 3, 2026
Collaborator
sanjayms01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pull this out into a separate util to be used across workflows?
sanjayms01
approved these changes
Feb 9, 2026
Ruchika4
approved these changes
Feb 11, 2026
Collaborator
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Resolves: MWPW-183090
Adding support for cgen authoring so that the cgen doesn't get localized.
Keeping it backward compatible.
Test URLs:
https://main--cc--adobecom.aem.page/drafts/vipulg/check/text-to-image-old
https://main--cc--adobecom.aem.page/drafts/vipulg/check/text-to-image-old?unitylibs=MWPW-183090
https://main--cc--adobecom.aem.page/drafts/vipulg/check/remove-object-old?unitylibs=MWPW-183090
https://main--cc--adobecom.aem.page/drafts/vipulg/check/text-to-image-new?unitylibs=MWPW-183090
https://main--cc--adobecom.aem.page/drafts/vipulg/check/remove-object-new?unitylibs=MWPW-183090
https://main--cc--adobecom.aem.page/drafts/vipulg/check/text-to-image-new
https://main--cc--adobecom.aem.page/drafts/vipulg/check/remove-object-new
old authoring:


new authoring: