elf: fix circular dependency in elf object#30
Open
abenkhadra wants to merge 1 commit intoaclements:masterfrom
Open
elf: fix circular dependency in elf object#30abenkhadra wants to merge 1 commit intoaclements:masterfrom
abenkhadra wants to merge 1 commit intoaclements:masterfrom
Conversation
object elf (parent) owns the memory of its children, namely, sections and segments. However, instances of the latter share memory ownership of the parent elf due to its pimpl implementation using shared_ptr. This creates a circular dependency that prevents cleaning the memory acquired by elf objects. I break this circular dependency through the standard mechanism of weak_ptr. Basically, the children now own a weak_ptr to the *implementation* of their parent elf object. They instantiate an instance of the parent only when an action involving the parent is needed.
|
This can also be solved by just changing "const elf f" member of segment and section to "const elf& f". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
object elf (parent) owns the memory of its children, namely, sections
and segments. However, instances of the latter share memory ownership
of the parent elf due to its pimpl implementation using shared_ptr.
This creates a circular dependency that prevents cleaning the memory
acquired by elf objects.
I break this circular dependency through the standard mechanism
of weak_ptr. Basically, the children now own a weak_ptr to the
implementation of their parent elf object. They instantiate
an instance of the parent only when an action involving the parent
is needed.