Add Android App Bundle (.aab) file support.

[ArkaprabhaChakraborty]

Fixes: aboutcode-org/scancode-toolkit#3640

[ArkaprabhaChakraborty]

Checked the CI job. My tests have passed but there are others that are breaking:

tests/test_androidappbundle.py::TestExtractAAB::test_can_identify_aab_file 
tests/test_androidappbundle.py::TestExtractAAB::test_can_extract_aab_file 
[gw1] PASSED tests/test_androidappbundle.py::TestExtractAAB::test_can_identify_aab_file 
tests/test_androidappbundle.py::TestExtractAAB::test_extract_aab_nonexistent_file 
[gw1] PASSED tests/test_androidappbundle.py::TestExtractAAB::test_extract_aab_nonexistent_file 
tests/test_archive.py::TestGetExtractorTest::test_7zip_extract_can_extract_to_relative_paths 

[pombredanne]

Thanks...

1. Can you find a very tiny bundle for testing? We also need to know where it is coming from and add an .ABOUT file to document its origin if possible, or a note explaining how to create it. Then please amend your commit with this small file
2. Is an aab a zip? if this is so, you should just add a handler for this as in

   extractcode/src/extractcode/archive.py

   Line 510 in db9dd08

   # Archive handlers.

   ... Do not recreate zip extraction. Same with the tests, if this a zip, then just add that file to the zip tests.
3. Is this code that was generated somehow? We are not against it, but this need to be stated upfront.

Generated code is most often approximate, and non-integrated in the rest of the code like your code here and it requires an inordinate amount of effort from maintainers to review, so we need to know

[ArkaprabhaChakraborty]

Yess .aab is signed zipfile. No it wasn't generated but I do use GitHub copilot free automcomplete extensions so it helps me with comments and documents. Actually I didn't know where to start so I decided to create a new file for it so that at least the idea can be presented. I did see a zipfile extractor already present but needed some information like how the information should be parsed and in what way it should be stored so that any other module could use it. I'll add the tests and handler to zipfile.

…

On Wed, Jan 29, 2025, 3:40 PM Philippe Ombredanne ***@***.***> wrote: ***@***.**** requested changes on this pull request. Thanks... 1. Can you find a very tiny bundle for testing? We also need to know where it is coming from and add an .ABOUT file to document its origin if possible, or a note explaining how to create it. Then please amend your commit with this small file 2. Is an aab a zip? if this is so, you should just add a handler for this as in https://github.com/aboutcode-org/extractcode/blob/db9dd083239302220b996bcf9c1914cd5c3ff016/src/extractcode/archive.py#L510 ... Do not recreate zip extraction. Same with the tests, if this a zip, then just add that file to the zip tests. 3. Is this code that was generated somehow? We are not against it, but this need to be stated upfront. *Generated code is most often approximate, and non-integrated in the rest of the code like your code here and it requires an inordinate amount of effort from maintainers to review, so we need to know* — Reply to this email directly, view it on GitHub <#68 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN6F3GM5MNS6I4YV6PQRMFT2NCSKHAVCNFSM6AAAAABV3I5GY2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBQGU2TMMRUHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>