Rewritten assert statements for more explicit checks#574
Rewritten assert statements for more explicit checks#574Dhruv276R wants to merge 2 commits intoaboutcode-org:developfrom
Conversation
|
Can you add a reference link in your commit message before your signoff: |
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thanks, can you amend your commit to add your DCO signoff?
Note that the other test failures may not be your making, but rather because of #576
|
@pombredanne |
| lic_score = about.license_score.value | ||
| assert len(lic_key) == len(lic_name) | ||
| assert len(lic_key) == len(lic_score) | ||
| if len(lic_key) != len(lic_name): |
There was a problem hiding this comment.
May be you can extract a variable?
| if len(lic_key) != len(lic_name): | |
| len_lics = len(lic_key) | |
| if len_lics != len(lic_name): |
and then use it in the messages and other tests below?
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thank you! Could you squash your commits, rewrite a proper commit message as explained in our documentation, add your DCO signoff, and force push?
|
Yeah I tried that but force pushing didn't seem to work for me. Let me do it again. |
2 participants
Fixes issue:
I have changed the assert statements to if and raise statements. It was a good first issue.