Open
Conversation
Srushtika
suggested changes
Feb 18, 2021
Srushtika
left a comment
Srushtika
left a comment
There was a problem hiding this comment.
Looks good, I've added a few comments in the individual files.
Re the PR itself, we usually have a separate branch for each tutorial, with different commits for different steps, matching the tutorial content. We have been debating, however, the usefulness vs the effort to add such stepwise commits. Since you've done that already, it may be worth updating the commit message for each, as it currently starts with step 3: https://github.com/ably/tutorials/pull/93/commits.
Also, the PR is raised against the main branch. We don't have any tutorials on main, so I'm assuming this is not intended to be merged in?
Author
|
Updated tags with latest commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tutorial code for inband occupancy tutorial. See docs repo for tutorial (PR #1027)