Make compatible to TensorFlow past Nov 6, 2017#64
Open
f0k wants to merge 1 commit intoabisee:masterfrom
Open
Conversation
|
This works fine. I wonder why this hasn't been accepted until now. |
ymfa
added a commit
to ymfa/pointer-generator
that referenced
this pull request
Apr 27, 2018
|
This is very useful. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the bit of the code which collects hyperparameters from command line flags into a named tuple. Since Nov 6 (commit 2652704), TensorFlow uses
absl.flags, which meansFLAGS.__flagsdoes not map keys to values any longer, but toFlaginstances. Directly collecting those leads to errors later in the code:This PR avoids accessing the internal
FLAGS.__flagssuch that it works fine with old and new versions of TensorFlow.