hour is printing but issue with min part; also need more efficient …#22
Open
Gabba42 wants to merge 1 commit intoZipcoder:masterfrom
Open
hour is printing but issue with min part; also need more efficient …#22Gabba42 wants to merge 1 commit intoZipcoder:masterfrom
Gabba42 wants to merge 1 commit intoZipcoder:masterfrom
Conversation
…y to populate maps....
thesleuth
reviewed
Dec 4, 2017
thesleuth
left a comment
thesleuth
left a comment
There was a problem hiding this comment.
Definitely a start in the right direction. You may want to break up the conversion by hours and minutes ot make it easier to repurpose the number to string indexing. Good choice on the collections use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…way to setup maps....