Open
Conversation
Git-Leon
reviewed
Feb 7, 2018
|
|
||
| } | ||
|
|
||
| public static boolean isBob (String name){ |
Contributor
There was a problem hiding this comment.
Good use of the SRP programming principle. 👍
| return false; | ||
| } | ||
|
|
||
| public static boolean isAlice (String name){ |
Contributor
There was a problem hiding this comment.
Thumbs up for the SRP 👍
Thumbs down for the code redundancy...
Notice the similarities between isBob and isAlice.
When you see patterns of redundancy like this, it means it can be abstracted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I somehow managed to push my workingbranch up to GitHub instead of my Master (this git stuff is confusing), but this is my final version of the program and I THINK this pull request will still allow me to turn it in?