Implement up/down/escape behaviour as ingame#893
Open
Helwor wants to merge 3 commits intoZeroK-RTS:masterfrom
Open
Implement up/down/escape behaviour as ingame#893Helwor wants to merge 3 commits intoZeroK-RTS:masterfrom
Helwor wants to merge 3 commits intoZeroK-RTS:masterfrom
Conversation
Browse through message history with up/down, escape clear the input field. Similar behaviour as ingame
sprunk
approved these changes
Jun 17, 2024
Member
sprunk
left a comment
sprunk
left a comment
There was a problem hiding this comment.
Haven't tested yet but code looks reasonable
Helwor
commented
Jun 19, 2024
Author
Helwor
left a comment
Helwor
left a comment
There was a problem hiding this comment.
I got also another change for this file to offer, but on a totally different part. Idk how to do.
The last update wasn't good, to stay at cursor on send it would need more coding around. Now it works exactly as ingame: not remembering the most recent message repeated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browse through message history with up/down, escape clear the input field. Similar behaviour as ingame