Conversation
inho-98
approved these changes
Jun 4, 2024
Contributor
inho-98
left a comment
inho-98
left a comment
There was a problem hiding this comment.
고생하셨습니다~!
추후에 API 연결해서 네트워킹 필요한 부분들 구현하면 될 것 같습니다! 👍🚀
Comment on lines
+11
to
+16
| class ProductInfoStackView: UIStackView { | ||
| enum Mode { | ||
| case starRating // 별점 | ||
| case date // 날짜 | ||
| case tastes // 취향 태그 | ||
| } |
Comment on lines
+36
to
+38
| private var dataSource: DataSource? | ||
| private var productDetail: ProductDetailEntity? | ||
| private var review: ReviewEntity? |
Contributor
There was a problem hiding this comment.
[C]
아래의 applySnapshot(with: , review:) 함수의 매개변수를 외부에서 전달받도록 하고 뷰컨 내부에서는 productDetail, review 같은 정보를 모르게 하는 방법은 어떨까요?
(뷰컨이 멍청하도록..!)
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat { | ||
| return UITableView.automaticDimension |
Contributor
There was a problem hiding this comment.
automaticDimension 지정해준 이유가 셀마다 다른 높이값 주기 위해서 인가요?
|
|
||
| import UIKit | ||
|
|
||
| struct MyReviewContentConfiguration: UIContentConfiguration { |
Contributor
There was a problem hiding this comment.
UIContentConfiguration 활용하는 방법 덕분에 배웠습니다 👍
KakaoTocs
reviewed
Jun 6, 2024
| class MyReviewContentView: UIView, UIContentView { | ||
| static let identifier = "MyReviewContentView" | ||
|
|
||
| var configuration: any UIContentConfiguration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이슈
#175
수정사항
(더미 데이터로 UI만 구현하였습니다.)
ProductDetailReviewCell버튼
ActionButtonCell로 분리reviewTagListView 길어지는 UI 이슈 수정
ProductInfoStackView리뷰 작성시 상단 상품 정보 뷰 재사용을 위해
ProductInfoStackView로 분리ProfileHomeViewControllerviewHolder 파일 분리
캐릭터 슬롯 & 내 리뷰 섹션 추가
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-02.at.18.33.59.mp4