Donation Visibility: Add Donate Button Near Download on Plugin Page#484
Open
nikunj8866 wants to merge 2 commits intoWordPress:trunkfrom
Open
Donation Visibility: Add Donate Button Near Download on Plugin Page#484nikunj8866 wants to merge 2 commits intoWordPress:trunkfrom
nikunj8866 wants to merge 2 commits intoWordPress:trunkfrom
Conversation
bramburn
reviewed
Apr 18, 2025
...ss.org/public_html/wp-content/themes/pub/wporg-plugins-2024/template-parts/plugin-single.php
Show resolved
Hide resolved
| if ( $donate_link ) { | ||
| $buttons .= sprintf( | ||
| '<!-- wp:button {"className":"is-small is-style-outline plugin-donate download-button"} --> | ||
| <div class="wp-block-button is-small is-style-outline plugin-donate download-button"><a class="wp-block-button__link wp-element-button" href="%1$s">%2$s</a></div> |
There was a problem hiding this comment.
Is this the right way to do the html. Are those classes default
Author
There was a problem hiding this comment.
Yes, I've followed the button HTML structure consistent with the existing elements such as Download, Live Preview, and Test Preview.
|
Looks good
…On Mon, 21 Apr 2025, 12:46 Nikunj Hatkar, ***@***.***> wrote:
@nikunj8866 <https://github.com/nikunj8866> requested your review on: #484
<#484> Donation
Visibility: Add Donate Button Near Download on Plugin Page.
—
Reply to this email directly, view it on GitHub
<#484 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUTT3N7NXAF2REYDO3TTED22TLCBAVCNFSM6AAAAAB2YXQAEWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXGMZTONJVGE2TQNQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta Trac: https://meta.trac.wordpress.org/ticket/7928
Issue: #501
This PR improves donation visibility by placing a more prominent "Donate" button next to the "Download" button on plugin pages. This aims to better support plugin developers by making the donation option more accessible to users.