Restrict self-removal for plugin committers.#483
Open
sebastienserre wants to merge 1 commit intoWordPress:masterfrom
Open
Restrict self-removal for plugin committers.#483sebastienserre wants to merge 1 commit intoWordPress:masterfrom
sebastienserre wants to merge 1 commit intoWordPress:masterfrom
Conversation
Updated logic to prevent committers from removing themselves. This ensures better user management and eliminates accidental self-removal scenarios. Code indentation was also adjusted for better readability.
Member
|
I don't think this is the optimal route, since there are times when you want to remove yourself from a plugin. I'd probably only restrict it when you're the owner of the plugin, or you're the only committer of the plugin. Perhaps this would be better implemented through a modal warning that they're about to remove themselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated logic to prevent committers from removing themselves. This ensures better user management.
Should fix https://meta.trac.wordpress.org/ticket/7947