Fixed bug in return of completed data for assault extdata

[Traelblaser]

Tweaks return value of completed as follows:
From: (buggy code)

To: (what was intended)

[Traelblaser]

No more nesting of the set inside another set

[z16]

Not too happy with the structure of the result table. I would return something like this:

return {
    type = 'Assault Log',
    area = 'Ilrusi', -- will need to be looked up based on ID
    log = {
        { name = 'Golden Salvage', completed = false },
        ...
    },
}

With my above suggestion, this could be:

return {
    type = 'Assault Log',
    area = missions[item_id].name,
    log = table.range(10):map(function(index)
        return {
            name = missions[item_id][index],
            completed = flags[index],
        }
    end),
}

[z16]

Would change this back to being raw strings, and assemble the name attribute later. Also, please move the missions table outside of the function and close over it, like this:

do
    local missions = {
        [2491] = { name = 'Leujaoam',
            [1] = 'Leujaoam Cleansing', -- also fix Leujaoam in this name please
            [2] = 'Orichalcum Survey',
            ...
        },
    }

    function decode.AssaultLog(item_id, str)
        -- use the `missions` variable here
    end
end