Env in tests #1446
Merged
Env in tests #1446
+190
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuri82
requested changes
Feb 12, 2026
| import java.lang.reflect.Method; | ||
| import java.net.InetSocketAddress; | ||
| import java.nio.file.Path; | ||
| import java.nio.file.Paths; |
Collaborator
There was a problem hiding this comment.
why these imports? are they used?
|
|
||
| @Experimental | ||
| @Cfg("Use environment variables to define the paths required by External Drivers. " + | ||
| "This is necessary when the generated tests are executed on the same machine. " + |
| String javaHome = System.getenv(envVarName); | ||
|
|
||
| if (javaHome == null || javaHome.isEmpty()) { | ||
| throw new RuntimeException("Cannot find "+envVarName); |
Collaborator
There was a problem hiding this comment.
"Environment variable does not seem to be defined: " + envVarName. also i guess it could be an IllegalArgumentException?
arcuri82
approved these changes
Feb 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add options to use env variables needed in external driver