-
Notifications
You must be signed in to change notification settings - Fork 103
Add support to xml data type #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support to xml data type #1393
Conversation
arcuri82
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suarezrominajulieta thx for your first PR! see comments
core/src/main/kotlin/org/evomaster/core/output/service/HttpWsTestCaseWriter.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/problem/rest/builder/RestActionBuilderV3.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/search/gene/ObjectGene.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/search/gene/ObjectGene.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/search/gene/ObjectGene.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/search/gene/ObjectGene.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/search/gene/ObjectGene.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/evomaster/core/search/gene/ObjectWithAttributesGene.kt
Outdated
Show resolved
Hide resolved
|
thank you for the comments! I'll look into them |
78fbc42 to
5617fa1
Compare
commit 4105091 Merge: a2aac9d 8fcd380 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Mon Feb 2 21:32:01 2026 -0300 Merge branch 'master' into master_temp commit a2aac9d Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Feb 1 21:49:29 2026 -0300 Fix tests commit c2b1461 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Feb 1 21:32:42 2026 -0300 Fixes for pr commit 1b4d1c7 Merge: cc9d149 7d0333f Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Feb 1 17:07:14 2026 -0300 Merge branch 'master' into master_temp commit cc9d149 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Thu Jan 29 19:45:12 2026 -0300 Try fixing Genes commit ee978c9 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Thu Jan 29 19:39:34 2026 -0300 Try excluding problematic genes commit 875653e Merge: fac65b4 39de778 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Thu Jan 29 00:22:31 2026 -0300 Merge branch 'master' into master_temp commit fac65b4 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Wed Jan 28 23:05:46 2026 -0300 whitebox test passed commit 437766c Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Wed Jan 28 21:16:01 2026 -0300 Fix whitebox commit a6c9666 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Tue Jan 27 21:47:53 2026 -0300 Change for items_item commit ccaee1a Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Tue Jan 27 00:15:10 2026 -0300 fix the faults tests for bbxml commit 2169cd9 Merge: 4f71753 1354ec1 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Mon Jan 26 18:29:57 2026 -0300 Merge branch 'master' into master_temp commit 4f71753 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Mon Jan 26 00:03:45 2026 -0300 Fixes for bbxmltest commit 62b2ff9 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Jan 25 23:01:11 2026 -0300 try to log the error commit b931cfd Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Jan 25 19:58:03 2026 -0300 try again commit 550fb33 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Jan 25 17:32:17 2026 -0300 try catch the error commit 29daedc Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Jan 25 10:15:51 2026 -0300 try only containssamevalueas commit 9f7c967 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Jan 25 02:34:42 2026 -0300 try without those functions commit ca6674c Merge: c4e495e e3eca4a Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sat Jan 24 11:27:12 2026 -0300 Merge branch 'master' into master_temp commit c4e495e Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sat Jan 24 00:09:29 2026 -0300 try 2nd version commit 8b3c79d Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sat Jan 24 00:07:16 2026 -0300 try this version commit 3b8441d Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Fri Jan 23 19:25:44 2026 -0300 try commit 74e95c5 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Fri Jan 23 00:35:51 2026 -0300 try commit 1f9adef Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Wed Jan 21 22:55:18 2026 -0300 try ci for sampler commit 2baac85 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Mon Jan 19 23:19:42 2026 -0300 fix _items not child commit 516e713 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Jan 18 23:33:21 2026 -0300 Quitamos el ref, dejamos el _items por el test de stacktrace commit ccde334 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sun Jan 18 00:54:21 2026 -0300 update reference in restAction for _items commit a62edfa Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sat Jan 17 23:18:30 2026 -0300 Update sampler commit 804d9eb Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sat Jan 17 20:30:40 2026 -0300 Update GeneSamplerForTests.kt commit 3638350 Merge: e4ec618 319e839 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sat Jan 17 19:11:16 2026 -0300 Merge branch 'master' into master_temp commit e4ec618 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sat Jan 17 18:49:45 2026 -0300 update tests commit 4cfe9d6 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Sat Jan 17 13:45:57 2026 -0300 some changes commit 2f677b5 Merge: ba340f1 af2b540 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Fri Jan 16 10:53:17 2026 -0300 Merge branch 'master' into master_temp commit ba340f1 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Fri Jan 16 10:53:05 2026 -0300 Update RestActionBuilderV3.kt commit db4c99f Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Fri Jan 16 00:57:28 2026 -0300 try ci commit 98f04c6 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Fri Jan 16 00:24:57 2026 -0300 Quito validacion que ya realiza objectGene commit 55b5c6c Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Wed Jan 14 23:57:23 2026 -0300 Change in white test and sut commit 5c150c4 Merge: 5096e0a 0869cd7 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Wed Jan 14 21:03:25 2026 -0300 Merge branch 'master' into master_temp commit 5096e0a Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Tue Jan 13 22:57:23 2026 -0300 Try ci without white box test commit 76fa3c7 Author: ROMINA JULIETA SUÁREZ <romi_de_munro@hotmail.com> Date: Mon Jan 12 20:41:29 2026 -0300 Try changes from rest and objectGene commit 13b3acf Author: Romihime <romi_de_munro@hotmail.com> Date: Wed Jan 7 00:04:11 2026 -0300 Try CI again commit b606ef4 Merge: 2204d25 6364863 Author: Romihime <romi_de_munro@hotmail.com> Date: Tue Jan 6 23:30:20 2026 -0300 Merge branch 'develop_xml2' into master_temp commit 2204d25 Merge: 78fbc42 5617fa1 Author: Romihime <romi_de_munro@hotmail.com> Date: Tue Jan 6 23:28:55 2026 -0300 Merge branch 'master' of https://github.com/suarezrominajulieta/EvoMaster commit 6364863 Author: Romihime <romi_de_munro@hotmail.com> Date: Mon Jan 5 23:36:29 2026 -0300 Add whitebox simple test commit 750380e Author: Romihime <romi_de_munro@hotmail.com> Date: Sun Jan 4 17:30:48 2026 -0300 try ci commit 2b533dd Author: Romihime <romi_de_munro@hotmail.com> Date: Thu Jan 1 12:26:11 2026 -0300 Fix: this is not a valid test commit 6b54851 Author: Romihime <romi_de_munro@hotmail.com> Date: Thu Jan 1 11:53:52 2026 -0300 Add test to ArrayGene and check if it prints ok with xml mode commit 0f1894a Author: Romihime <romi_de_munro@hotmail.com> Date: Mon Dec 29 23:59:54 2025 -0300 Fixed the application, only missing the [ fix on arrays commit 72ca9e3 Author: Romihime <romi_de_munro@hotmail.com> Date: Mon Dec 29 00:25:27 2025 -0300 We need name otherwise it is body commit 170dd03 Author: Romihime <romi_de_munro@hotmail.com> Date: Sun Dec 28 23:47:44 2025 -0300 Move objectWithAttributesGeneTest and fix logs commit 18ad2c9 Author: Romihime <romi_de_munro@hotmail.com> Date: Sun Dec 28 18:19:45 2025 -0300 Seven out of nine comments commit fbb6378 Author: Romihime <romi_de_munro@hotmail.com> Date: Sun Dec 28 00:01:49 2025 -0300 try ci commit 5110c21 Author: Romihime <romi_de_munro@hotmail.com> Date: Sun Dec 21 21:30:24 2025 -0300 try commit e502b99 Author: Romihime <romi_de_munro@hotmail.com> Date: Mon Dec 15 20:06:05 2025 -0300 Somefixes commit 78fbc42 Merge: 4a89841 9204b77 Author: Juan Pablo Galeotti <jgaleotti@gmail.com> Date: Wed Nov 26 09:52:54 2025 -0300 Merge pull request #2 from suarezrominajulieta/develop_xml2 support for XML attributes using ObjectGeneWithAttributes commit 9204b77 Merge: fb8565e 4a89841 Author: Romihime <romi_de_munro@hotmail.com> Date: Tue Nov 25 22:47:20 2025 -0300 Merge branch 'master' into develop_xml2 commit fb8565e Author: Romihime <romi_de_munro@hotmail.com> Date: Tue Nov 25 19:17:37 2025 -0300 Try commit 0325e67 Author: Romihime <romi_de_munro@hotmail.com> Date: Tue Nov 25 07:57:08 2025 -0300 Fix commit 801575a Author: Romihime <romi_de_munro@hotmail.com> Date: Mon Nov 24 22:01:42 2025 -0300 Changes from pr commit 4336523 Author: Romihime <romi_de_munro@hotmail.com> Date: Wed Nov 19 22:16:21 2025 -0300 Fix cuantity of genes commit efac187 Merge: 9303840 5bbad0a Author: Romihime <romi_de_munro@hotmail.com> Date: Wed Nov 19 20:24:18 2025 -0300 Merge branch 'master' into develop_xml2 commit 9303840 Author: Romihime <romi_de_munro@hotmail.com> Date: Wed Nov 19 20:03:21 2025 -0300 Fix restActionBuilderV3 commit c739885 Author: Romihime <romi_de_munro@hotmail.com> Date: Wed Nov 19 19:48:08 2025 -0300 Update HttpWsTestCaseWriter.kt commit 87e97ab Author: Romihime <romi_de_munro@hotmail.com> Date: Mon Nov 17 21:22:30 2025 -0300 New branch_xml due to changes from master
|
Hi Andrea @arcuri82 , how are you? Sorry for the delay, I made a few changes to the comments and added the tests. I'd appreciate it if you had a moment to look at them. Thank you very much! |
|
|
||
| @Test | ||
| fun testRunEM() { | ||
| runTestHandlingFlakyAndCompilation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not how BB tests should be written in this module. they should follow the structure:
@ParameterizedTest
@EnumSource
fun testBlackBoxOutput(outputFormat: OutputFormat) {
executeAndEvaluateBBTest(
see all other tests in this module, in particular the use of CoveredTargets.cover()
| } | ||
|
|
||
| var gene = getGene("body", obj.schema, schemaHolder,currentSchema, referenceClassDef = null, options = options, messages = messages, examples = examples) | ||
| val deref = obj.schema.`$ref`?.let { ref -> SchemaUtils.getReferenceSchema(schemaHolder, currentSchema, ref, messages) } ?: obj.schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unclear. need to add some comments to explain "why" this is done.
| override fun getValueAsPrintableString(previousGenes: List<Gene>, mode: GeneUtils.EscapeMode?, targetFormat: OutputFormat?, extraCheck: Boolean): String { | ||
| return openingTag + | ||
|
|
||
| val(open,close,sep) = if (mode == GeneUtils.EscapeMode.XML){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment to explain this
|
|
||
| assertEquals("[10, 20, 30]", jsonOutput) | ||
|
|
||
| assertTrue(jsonOutput.startsWith("["), "JSON debe empezar con corchete de apertura") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error messages should not be in Spanish, but English :)
| val containsSame = x.containsSameValueAs(y) | ||
| if (containsSame) { | ||
| // Debug info: find which child gene has the inconsistency | ||
| val debugInfo = buildString { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be refactored to a call to a private method
| } | ||
| appendLine("=== END DEBUG ===") | ||
| } | ||
| System.err.println(debugInfo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this debugInfo should not go on System.err.println, but rather appended to the error message of the assertFalse
| it.isLocallyValid() | ||
| } | ||
| it.isLocallyValid() | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation here does not seem nice. should avoid changing indentation of existing code
|
|
||
| @Test | ||
| fun testXmlSerializationEmptyArray(){ | ||
| // Test para verificar que un array vacío en XML no genera corchetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments should only be written in English
No description provided.