feat: Refactor localization with new lore array format and placeholders#568
Open
IPECTER wants to merge 2 commits intoVolmitSoftware:mainfrom
Open
feat: Refactor localization with new lore array format and placeholders#568IPECTER wants to merge 2 commits intoVolmitSoftware:mainfrom
IPECTER wants to merge 2 commits intoVolmitSoftware:mainfrom
Conversation
- Migrate from lore1/lore2 keys to unified lore arrays
- Add MessageFormat placeholders ({0}, {1}) for dynamic values
- Standardize color formatting (<green>, <red>, <yellow>)
- Update en_US to new structure (others need translation)
- Refactor Localizer.dLocalize() to support dot notation keys
IPECTER
commented
Jan 24, 2026
|
|
||
| return this; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I don't know if it's because of my JAVA_HOME, but the method kept failing to compile.
NextdoorPsycho
approved these changes
Jan 24, 2026
Contributor
NextdoorPsycho
left a comment
NextdoorPsycho
left a comment
There was a problem hiding this comment.
Cool
- Only Hesitation is the Impact on the Localizer (Gitlocalize)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well… I changed quite a bit.
New structure, updated English source text, so all languages need fresh translations.
The repetitive stuff went to Claude Opus.
So far, nothing seems broken.