Fix Hardware and Tender Settings button type bugs #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hardware Button Type fixes: - Fixed printer deletion on every startup (only migrate if server has no printer) - Fixed terminal iterator reset after cleanup loop - Fixed multiple terminals being marked as server (update have_server count) - Fixed FindServer priority to check IsServer flag first Known issue: Duplicate Server displays may still appear - investigation ongoing Tender Settings fixes: - Added null pointer checks in KillRecord for all sections - Added consistent display_id/record_no handling for Coupons, Credit Cards, Comps, Employee Meals Files modified: - main/data/manager.cc - main/data/settings.cc - zone/settings_zone.cc - docs/changelog.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardware Button Type fixes:
Known issue: Duplicate Server displays may still appear - investigation ongoing
Tender Settings fixes:
Files modified: