Skip to content

Conversation

@QtRoS
Copy link

@QtRoS QtRoS commented Feb 1, 2026

Automatically parsed and replaced (with regexp, not AI) most of appid literals in proton. Why? Because 3 year old comment says:

#hopefully short-lived, app-specific workarounds for Proton bugs

Seems that it's time to make such lists legit, because makes codebase look a bit more solid :)

BTW, I left old ids in comments like this:

if appid in [
                AppID.AS_DUSK_FALLS, # 1341820
                AppID.CREATIVERSE, # 280790
                AppID.THE_ELDER_SCROLLS_ONLINE, # 306130

only to simplify review process. Once it's done they can be removed IMO.

P.S. Maybe this function worth adding to appids.py:

def name_to_constant(name):
    name = name.upper()
    name = re.sub(r"[\"'\[\]\(\):®]", '', name)
    name = re.sub(r'[ &\-\.,/+]+', '_', name)
    name = re.sub(r'__+', '_', name)
    return name.strip('_')

Later everyone can use it to add new games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant