Open
Conversation
VagishVela
requested changes
Sep 12, 2021
Owner
VagishVela
left a comment
VagishVela
left a comment
There was a problem hiding this comment.
A couple comments around stackoverflow. Rest looks good.
| page.append_text(Text("<- Prev Page 0/0 Next ->")) | ||
| if i != len(contents) - 1: | ||
| page.append_text(Text("\n\n")) | ||
| page.append_text(Text("3cksjusdkcjsady")) |
Owner
There was a problem hiding this comment.
Should we hardcode this? Or maybe generate something random programmitcally? Just feels weird to me. Also this is a Stackoverflow specific method, should it be in Stackoverflow parts of the code rather than here?
| output = "".join(output) | ||
|
|
||
| return "<- Prev Page 0/0 Next ->" not in output | ||
| return "3cksjusdkcjsady" not in output |
Owner
|
@ethansocal Did you want to update this? I'll review it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses a new Rich 10.8.0 feature, so you may have to run
poetry installagain before running this branch.