Merged
Conversation
bobular
reviewed
Feb 13, 2025
Member
bobular
left a comment
bobular
left a comment
There was a problem hiding this comment.
Looks good - just one comment!
| if (idColumn %in% names(.dt) && nrow(.dt) == uniqueN(.dt[[idColumn]])) { | ||
| idCol <- idColumn | ||
| } else { | ||
| idCol <- NULL |
Member
There was a problem hiding this comment.
Hi! Should this maybe throw an error? Seems like there will be downstream trouble if we asked for point IDs and there's no column to get them from?
Member
Author
There was a problem hiding this comment.
That's a good idea! I'll add it.
Member
|
Looks good to me on my phone! Consider it approved.
…On Thu, 13 Feb 2025, 15:45 Ann Sizemore Blevins, ***@***.***> wrote:
@asizemore <https://github.com/asizemore> requested your review on: #264
<#264> Have scatter return
point ids.
—
Reply to this email directly, view it on GitHub
<#264 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACLLH4PPNYFK2PGLT5ZYXT2PS4YHAVCNFSM6AAAAABWWZPW3WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGI4TQNZWGAYDEMA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #263
The scatterplot will now return the ids of points if an id column is given and
returnPointIds = TRUE.NOTE: This feature was not implemented for the case where
value=densitynor for when thecorrelationMethod != 'none'. I attempted both, found the former very tough to debug, and found that the latter already was erring (seemain). Since neither are part of production code, nor do we have any plans to make them production code, I'm leaving them as is. I also commented out the failing correlation tests.