fix: correct return type of getDefaultReactSlashMenuItems to include key #2416
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect return type of
getDefaultReactSlashMenuItems()to properly include thekeyproperty.Rationale
Items returned by
getDefaultReactSlashMenuItems()actually contain akeyproperty (inherited fromgetDefaultSlashMenuItems()), but the return typeDefaultReactSuggestionItem[]omitskey. This causes type errors when users try to accessitem.key:Changes
getDefaultReactSlashMenuItems()to includekeypropertygetPageBreakReactSlashMenuItems()by removing unnecessaryOmitImpact
item.keywithout type errorsTesting
Screenshots/Video
N/A (type-only change)
Checklist
Additional Notes