-
Notifications
You must be signed in to change notification settings - Fork 1
qubes-dom0-packagev2.yml: update for latest builderv2 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The updated building workflow is meant to be ran on a GitHub worker with Ubuntu 24.04. For this case the workflow disables AppArmor and, given the required recent Sequoia release, installs Rust with the recommended method available at https://rust-lang.org/tools/install/. Signed-off-by: Kamil Aronowski <kamil.aronowski@3mdeb.com>
bdbba48 to
b102a70
Compare
| with: | ||
| repository: QubesOS/qubes-builderv2 | ||
| ref: 80dd898cc0472dd99f161f1d1c7c44da64de93f2 | ||
| ref: 5327e41b3d68befc61bee87fb1ac0033662d575f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a reason for this change to commit message.
| - name: Save built packages | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| if-no-files-found: error | ||
| name: qubesos.dom0.fc37-${{ inputs.qubes-component }}-${{ github.sha }} | ||
| path: '*.rpm' | ||
|
|
||
| - name: Construct release's description | ||
| if: github.event_name == 'push' && github.ref_type == 'tag' | ||
| run: | | ||
| for artifact in *.rpm; do | ||
| echo "### $artifact" >> release-body.md | ||
| echo '```' >> release-body.md | ||
| echo "wget --quiet '${{ github.server_url }}/${{ github.repository }}/releases/download/${{ github.ref_name }}/$artifact'" >> release-body.md | ||
| echo '```' >> release-body.md | ||
| echo '```' >> release-body.md | ||
| echo "curl --remote-name '${{ github.server_url }}/${{ github.repository }}/releases/download/${{ github.ref_name }}/$artifact'" >> release-body.md | ||
| echo '```' >> release-body.md | ||
| done | ||
|
|
||
| - name: Create release for a new tag | ||
| if: github.event_name == 'push' && github.ref_type == 'tag' | ||
| uses: ncipollo/release-action@v1.14.0 | ||
| with: | ||
| artifacts: '*.rpm' | ||
| artifactErrorsFailBuild: true | ||
| bodyFile: "release-body.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not publish untested and unsigned packages on GitHub release page. Please, make sure this workflow publishes packages only on https://dl.3mdeb.com/tmp/rpm/QubesOS under current-testing for needed QubesOS release number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed internally, my comment here is not correct, as in this project project it is acceptable to do such pushes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot resolve my thread unfortunately, but assume it is resolved.
The updated building workflow is meant to be ran on a GitHub worker with Ubuntu 24.04. For this case the workflow disables AppArmor and, given the required recent Sequoia release, installs Rust with the recommended method available at https://rust-lang.org/tools/install/.