A self.self slipped into the code.#77
Open
adonoho wants to merge 18 commits intoTransitApp:masterfrom
Open
Conversation
A self.self slipped into the code. This introduced some anomalous behavior to this new user of the class. Removing the redundant selfs returned to the expected bahvior of the buttons.
…view controllers events.
…eing merged and forgotten.
…g https. It also simplified the code and shifted responsibility to Google on how to use their product.
…s the web view's ongoing memory use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A self.self slipped into the code. This introduced some anomalous
behavior to this new user of your class. Removing the redundant selfs
returned to the expected bahvior of the buttons.