Make transcrypt-loader npm package Windows-compatible#750
Open
phistrom wants to merge 2 commits intoTranscryptOrg:parcel-bundler2from
Open
Make transcrypt-loader npm package Windows-compatible#750phistrom wants to merge 2 commits intoTranscryptOrg:parcel-bundler2from
phistrom wants to merge 2 commits intoTranscryptOrg:parcel-bundler2from
Conversation
index.py checks path.sep and converts all backslashes to forward slashes Fixed possibly incorrect babel invocation in package.json incremented transcrypt-loader version to 1.0.3
This code only seems to exist on the parcel-bundler2 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #624 by checking if we are running on Windows and replacing the backslashes in
import_pathwith forward slashes. The main change is https://github.com/QQuick/Transcrypt/compare/parcel-bundler2...phistrom:parcel-bundler2?expand=1#diff-ba37ae7716bc43a1a120b784aee4b09eR44.I think @doconix will have to be the one to upload to npm.