Open
Conversation
added 2 commits
November 8, 2023 11:05
…nge pixels coords to lower origin, can convert line+Rcs traces on detector to 2D image
…wavelength, add if already exists name of wavelength (dlamb dict)
|
Hello @adriendaros! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-01-17 08:41:59 UTC |
added 7 commits
November 9, 2023 12:27
…ectra, add mode in arguments
…ed, plot RCs vs wavelengths option ok,
…length, plot parameter supdated,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aim :
Modifications on the routine
tofu/geom/plot_line_on_det_tracing()have been made in order to integrate multiple lines tracing at the same time, in order to simulate a 2D spectra (w/o line intensities, only positions).Main changes:
Are available:
lamb = 'ArXVII'w/ArXVII (w,x,y,z),ArXVI (q,r,a,k,j),ArXV (n=3),WXLIVandWXLIIIlineslamb = 'ArXVII-woW'w/ArXVII (w,x,y,z),ArXVI (q,r,a,k,j)andArXV (n=3)lineslamb = 'ArXVII-wxyz'w/ArXVII (w,x,y,z)lineslamb = Nonetake the wavelength of reference of the crystal usedphi(by default to 100)mode = 'raw det'merge_rc_data = True+plot_simu_image = TrueExamples: