Issue#75 sa triangle

[lasofivec]

[pep8speaks]

Hello @lasofivec! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file setup.py:

Line 178:80: E501 line too long (80 > 79 characters)

• In the file tofu/tests/tests01_geom/test_04_sampling.py:

Line 388:80: E501 line too long (87 > 79 characters)
Line 443:80: E501 line too long (82 > 79 characters)
Line 471:24: E231 missing whitespace after ','
Line 472:17: E265 block comment should start with '# '
Line 473:41: E231 missing whitespace after ','
Line 539:80: E501 line too long (80 > 79 characters)
Line 550:21: E265 block comment should start with '# '
Line 551:45: E231 missing whitespace after ','

Comment last updated at 2021-12-21 22:01:02 UTC

[Didou09]

Shall we wait for this PR before the deployment of 1.4.11?
It has to be done before 13h today, what do you think?

[Didou09]

Hum... the tests for the 1.4.11 are still failing because of openadas, so it looks like you have more time

[Didou09]

@lasofivec, here the routine _vt.triangulate_polys() is called with the first argument as &data[0]
Here data is defined as data = <double **> malloc(npoly * sizeof(double *))

But in line 2812 (in routine def vignetting(), the same routine is called with the first argument as data.
And there data is defined as data = <double **> malloc(nvign*sizeof(double *))

So in both cases, data refers a similar object (a double pointer to an array of type double ?).

But in here it is provided as a memory address of the first element (&data[0]), while in line 2812 it is provided directly (data)

Questions:

• Why this difference ?
• Is it a bug ?
• Which one is correct ?

The definition of the routine, in _vignetting_tools.pyx (line 291) says it should have a double pointer of type double** as first argument. Which leads to think that only the first case (here, line 5170 is correct).

More questions:

• Why provide &data[0] and not &data[ii] ?
• Why use a double pointer instead of a single pointer in the routine definition ?
• Why provide a pointer only to the first element to data ?

[Didou09]

why give a pointer (&ucrossv[0]) ? The routine takes an array (see definition)

[lasofivec]

To be sure it will take the actual array and not a copy of it. So that the array is modified on exit. Not really necessary but some people prefer to do it to make sure everything is modified properly.
And an array is a pointer.