Use Exponent: Look ma, no native modules 👌#12
Use Exponent: Look ma, no native modules 👌#12cem2ran wants to merge 8 commits intoThinkmill:masterfrom
Conversation
app/scenes/Schedule/index.js
Outdated
| import type { ScheduleTalk } from '../../types'; | ||
|
|
||
| import Splash from 'react-native-smart-splash-screen'; | ||
| // import Splash from 'react-native-smart-splash-screen'; |
There was a problem hiding this comment.
Alright, I cheated slightly. But maybe it can do without?
There was a problem hiding this comment.
actually this splash screen is easy to make in Exponent! see PR to your repo
There was a problem hiding this comment.
That component is there just to make sure there's a smooth transition from the app loading to the animation at start. The flow currently is:
- LaunchScreen.storyboard shows the image.
- react-native-smart-splash-screen shows the same image while react native populates the Schedule scene.
- Once the component is mounted, react-native-smart-splash-screen fades out, revealing the 'real' components, which then animate.
I'm not sure in general whether we want to move to Exponent or not, but that's what it's currently doing.
There was a problem hiding this comment.
Yeah we don't have great support for a splashscreen that animates into the app for various reasons. It works meh on iOS right now, didn't bother tweaking it further because the image loader will always potentially cause a flicker. Either way, I'll keep the fork updated at https://expo.io/@community/reactconf2017 :)
There was a problem hiding this comment.
@JedWatson - might be worth pulling my changes for useNativeDriver in the schedule ListView in though
There was a problem hiding this comment.
@brentvatne, thanks for that! I'll pull in some of those changes, but for example I don't see a need for an Animated.ListView as the list view never moves. Let me know if I'm missing something.
There was a problem hiding this comment.
@blargity - AnimatedListView lets you run the animations in response to onScroll on the UI thread: http://facebook.github.io/react-native/blog/2017/02/14/using-native-driver-for-animated.html -- it makes the animation happen immediately in response to the scroll and so it doesn't drop frames when you page in new rows in the listview
There was a problem hiding this comment.
@brentvatne, thanks for that. I've tried to pull those changes in but I'm still getting an error that I've never seen before. Details are in #44, and the work is on a branch to make it easy to reproduce.
Add splash screen, preload images, use native driver
|
Thank you, but at this stage we're not looking to move over to Exponent. I'll go ahead and close this PR, but feel free to keep it up to date with master on your side! |
4 participants
Converted the app to use Exponent as all the needed modules already were provided by Exponent. (almost, not Microsoft code-push, but Exponent has their own flavour built-in)
Some tests are failing
due toI believe the snapshots just have to be updated.SyntaxError: Unexpected token import. Not sure why.