Growth 1304 fix memory issue #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgoraya
reviewed
Feb 12, 2026
rgoraya
reviewed
Feb 12, 2026
| def flush(page) | ||
| filename = filename_for_page(page) | ||
| doc = build_xml_for_page(paginator.items(page)) | ||
| def flush |
There was a problem hiding this comment.
Same here, why not just keep using flush(page) and when needed send current_page as the value of that param?
Author
There was a problem hiding this comment.
Here I'm not so sure, because I need to update the value of @current_page as well and it's not a good idea to modify the value of an input param. Also, it doesn't make sense to "flush" pages other than the current page, because we are dropping them as soon as they are processed.
johnholdun
approved these changes
Feb 12, 2026
johnholdun
left a comment
johnholdun
left a comment
There was a problem hiding this comment.
Seems good, but unless I'm mistaken, Paginator is no longer needed here. It's being recreated every time its collection reaches the limit, so it will always only return one page of results, and thus could be replaced by an array.
rgoraya
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GROWTH-1304
Description
Previously, each time we loaded the max amount of urls per file (defined by the @max_urls config variable) we generated a new sitemap file and released the memory, then we repeated the process until all urls were processed. This allowed us to load a huge amount of urls without clogging all our memory.
At some point this feature was lost and sitemap files started to be generated only at the very end of the process. This means that the process starts to accumulate more and more memory and if there's too many urls to process we get a memory overload error.
This PR fixes the issue by restoring the capability to generate sitemap files each time we reach the limit defined by the @max_urls config variable.