Removed deprecated CMake functions and removed unused link#4
Open
nepp95 wants to merge 2 commits intoTheCherno:mainfrom
Open
Removed deprecated CMake functions and removed unused link#4nepp95 wants to merge 2 commits intoTheCherno:mainfrom
nepp95 wants to merge 2 commits intoTheCherno:mainfrom
Conversation
Author
|
I should add: If you want to reference a specific commit, that can also be put in place of the tag with the same syntax (also using GIT_TAG). This is the recommended way per CMake documentation, although a tag in most cases should suffice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated CMake functions as well as removing the call to link the glm library which is never compiled, only included as a header. There also was a compilation error because of not including the vector std lib.
As part of updating the CMake function, the
find_packagecalls are also redundant since they can be done as part of theFetchContent_Declarecall. When addingFIND_PACKAGE_ARGSto the call, it will attempt to find it first usingfind_package.This ensures this repository stays relevant and compilable out of the box instead of having to fix the CMakeLists file in the future. On most modern CMake versions, the current version already spits out warnings while configuring.