use GCC_PREPROCESSOR_DEFINITIONS#23
Open
jberkel wants to merge 1 commit intoTestingWithFrank:masterfrom
jberkel:master
Open
use GCC_PREPROCESSOR_DEFINITIONS#23jberkel wants to merge 1 commit intoTestingWithFrank:masterfrom jberkel:master
jberkel wants to merge 1 commit intoTestingWithFrank:masterfrom
jberkel:master
Conversation
the problem with GCC_PREPROCESSOR_DEFINITIONS_NOT_USED_IN_PRECOMPS is that it is causing compilation errors when compiling the project with `-Werror` / `-Weverything` (unused macro warning)
Contributor
|
I'm sympathetic to wanting to use -Werror and -Weverything, but I don't think this will fix the problem in all cases. Are you using the FRANKIFIED macro in your precompiled header? For users who don't use the FRANKIFIED macro at all, I think they'll still get an error. And in general, we don't want to use GCC_PREPROCESSOR_DEFINITIONS, because we don't want to insert symbols into the project's precompiled header. |
Contributor
|
I'm not sure there's a good solution to this problem except to use the FRANKFIED macro somewhere if you have -Werror and -Weverything turned on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the problem with GCC_PREPROCESSOR_DEFINITIONS_NOT_USED_IN_PRECOMPS is
that it is causing compilation errors when compiling the project with
-Werror/-Weverything(unused macro warning)