Open
Conversation
zqfan
reviewed
Feb 7, 2025
| return self.role | ||
| except Exception as e: | ||
| raise TencentCloudSDKException("ClientError.MetadataError", str(e)) | ||
| finally: |
Member
There was a problem hiding this comment.
这里有可能是故意如此,区别的点是,到底是获取角色名失败后就抛出异常,还是继续使用原先的角色名。如果获取角色名失败,通常是medatada出问题了,那么后续获取toen时也会失败,最终就是密钥失败,所以晚失败和早失败比没有差别。提前抛出异常,就是让获取角色名成为关键前置条件,而实际上,只有首次获取角色名才是关键前置条件,后续虽然也有极低概率有(角色名被用户换了),但不是常态。所以早失败可能引入更多问题。
不过以上讨论可能都太极端了,也许在sdk场景下我们不需要考虑如此复杂细微的差异。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #195