feat(blog): Start SSR performance article #692
Draft
+341
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
|
|
||
| We improved TanStack Start's SSR performance dramatically. Under sustained load (100 concurrent connections, 30 seconds): | ||
|
|
||
| <!-- these are matteo's numbers, they don't look amazing (low throughput), maybe we should use our own numbers? we'll cite his in the conclusion anyway. --> |
Contributor
There was a problem hiding this comment.
yes use our own so we can actually compare this to later measurements
| // After: server gets a simple snapshot | ||
| function useRouterState() { | ||
| if (isServer) return router.store // no subscriptions on the server | ||
| return useStore(router, { ... }) // regular behavior on the client |
Contributor
There was a problem hiding this comment.
we should add a comment that isServer is static and thus rule of hooks does not apply here /or is not violated
|
|
||
| ### The mechanism | ||
|
|
||
| Client code cares about bundle size. Server code cares about CPU time per request. Those constraints are different (this is a _general_ rule, not a _universal_ one). |
Contributor
There was a problem hiding this comment.
whats 'general' vs 'universal' ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.