Open
Conversation
himanshu219
reviewed
Feb 1, 2019
| if(samplingPercent == 0) { | ||
| var increment = 0; | ||
| } else { | ||
| var increment = 100/samplingPercent; |
Contributor
There was a problem hiding this comment.
let's type cast this to integer so that increment is a natural number always.
Also I think we should have a condition samplingPercent > 0 and <= 100 and then we can run a for loop inside it.
Also would be good to break this into two separate functions one for filtering and other for sampling. Filtering one returns filtered + tobesampled records and takes records as input
while sampling one takes tobesampled records and sampling percent as input and returns sampled records
later on we merge the filtered and sampled records
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.