Skip to content

Conversation

@ttaylor-stack
Copy link
Collaborator

@ttaylor-stack ttaylor-stack commented Feb 3, 2026

SPARK-70

Figma

Along with updating the link component I also:

  • Removed a tag styling from s-link
  • Updated s-anchors to fix a11y failing tests
  • Updated Link Svelte component to Svelte 5
  • Updated Link stories to match the formatting/styling we use throughout the rest of the Storybook

Questions/Concerns:

  • @CGuindon do we need to force visited styling any more (using __visited)? If not can we remove it from the from Stacks?

@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit e58e3fd
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/698325fb6ab1b100083733cd
😎 Deploy Preview https://deploy-preview-2164--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2026

⚠️ No Changeset found

Latest commit: e58e3fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ttaylor-stack ttaylor-stack changed the title feat(link) - Update link component to SI feat(link) - Update link component to SHINE designs Feb 3, 2026
@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit e58e3fd
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/698325fb6717e400084375f1
😎 Deploy Preview https://deploy-preview-2164--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ttaylor-stack ttaylor-stack added the do-not-merge Pull requests that are in progress and should not be merged yet label Feb 3, 2026
@ttaylor-stack ttaylor-stack marked this pull request as draft February 3, 2026 09:52
@ttaylor-stack ttaylor-stack removed the do-not-merge Pull requests that are in progress and should not be merged yet label Feb 3, 2026
@ttaylor-stack ttaylor-stack marked this pull request as ready for review February 3, 2026 13:52
Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1 to Giarmir's comments about the underlines:

Looks like all the navigation elements now are underlined. Probably something we don’t want I imagine. Regular a  tag also now get a strange blue color which is probably something we don’t want.

New request (I've updated the Figma)
I have two small changes I'd like to make (sorry) to the original spec since we can't change the bold to unbold for visited (security reasons from the browser).

  • Default visited link should be black-400 now (used to be 500)
  • Muted visited link should be black-400 now as well (used to be 500 too, muted visited won't have a visual difference anymore. This isn't used in as many places so I'd like to test it and see how important the visited state really is for these types of links).

@dancormier
Copy link
Contributor

dancormier commented Feb 3, 2026

@ttaylor-stack I've removed the __visited modifier (16ba78f) and have added styles to handle anchors on a per-component basis (7e7bb5d).

@dancormier
Copy link
Contributor

@CGuindon I updated the colors and have this now:

Default

image

Hover

image

Visited

image

Does this look correct?

@CGuindon
Copy link
Collaborator

CGuindon commented Feb 4, 2026

@dancormier Colors look correct — is it possible to get the underline on hover (for all of them) as well? If that over complicates I can live without out. Seeing the underline in the docs

@CGuindon
Copy link
Collaborator

CGuindon commented Feb 4, 2026

Links page looks good, I'm seeing extra underlines in a few places where they shouldn't be like:

  • Menus
  • Breadcrumbs (although we haven't changed that component yet)
Screenshot 2026-02-03 at 4 18 04 PM Screenshot 2026-02-03 at 4 17 24 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants