-
Notifications
You must be signed in to change notification settings - Fork 102
feat(link) - Update link component to SHINE designs #2164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CGuindon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 1 to Giarmir's comments about the underlines:
Looks like all the navigation elements now are underlined. Probably something we don’t want I imagine. Regular
atag also now get a strange blue color which is probably something we don’t want.
New request (I've updated the Figma)
I have two small changes I'd like to make (sorry) to the original spec since we can't change the bold to unbold for visited (security reasons from the browser).
- Default visited link should be
black-400now (used to be 500) - Muted visited link should be
black-400now as well (used to be 500 too, muted visited won't have a visual difference anymore. This isn't used in as many places so I'd like to test it and see how important the visited state really is for these types of links).
|
@ttaylor-stack I've removed the |
|
@CGuindon I updated the colors and have this now: DefaultHoverVisitedDoes this look correct? |
|
@dancormier Colors look correct — |
…tackExchange/Stacks into spark-70/update-link-component


SPARK-70
Figma
Along with updating the link component I also:
Questions/Concerns: