Removed decoding step and activate decoding by client#2
Open
L1m3D4rkn3ss wants to merge 1 commit intomainfrom
Open
Removed decoding step and activate decoding by client#2L1m3D4rkn3ss wants to merge 1 commit intomainfrom
L1m3D4rkn3ss wants to merge 1 commit intomainfrom
Conversation
|
I had |
jgsch
suggested changes
Jul 25, 2022
| output = json.loads(output.decode()) | ||
|
|
||
| # Setup progress bar | ||
| num_steps = int(output["stream"].split()[1].split("/")[-1]) |
Contributor
There was a problem hiding this comment.
This will not work because we need the output to determine the number of steps.
Case like this (b'{"stream":"\\n"}\r\n') happend lot of times during the build, just ignore with something like:
output = json.loads(output.decode().split("\n")[0])Maybe add this to the other place where we decode the docker output if it happend at all step.
There was a problem hiding this comment.
I think the pattern is not regular, sometimes there is a lot of /n before the content we want. but I will try ur solution nevertheless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


FIX
There was an issue when decoding the docker logs with the json package on @bibs2091 's machine. Removing the two-step decoding and adding the
decodeargument to theclient.build()call seems to fix the issue.Additional context
@bibs2091 please add screenshots and error logs as well as your hardware, OS and software versions for everything.