Open
Conversation
Remove boilerplate and let setupmeta do the work
Author
|
Demonstration, python setup.py explain: Building and uploading work the same. But as a result, pip install works: The PR will work as-is. But, if you want to, like me, test with another package namespace then you will need to hardcode packages as such: Njoy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this works
pip install -e git+https://github.com/Spredzy/python-c14.git#egg=c14This PR also enables
python setup.py uploadto produce an uploaded file that will work withpip install c14, which otherwise results in quite some pain:The approach taken by this patch is to remove boilerplate and let setupmeta do the work.