Open
Conversation
Member
|
HI @vncntprvst Thank you so much for this and sorry for our delay in reviewing. Will get nack into this by the end of the week :) I think that adding CUDA versions to the tag is a good idea. I'll do it for Kilosort4 too! |
alejoe91
reviewed
Mar 4, 2024
| docker build -t spikeinterface/pykilosort-base:latest -t spikeinterface/pykilosort-base:ibl-1.4.7_cuda-11.5.2 . | ||
|
|
||
| # version info | ||
| # 01/21/2024 - IBL 1.4.7 CUDA 11.3.1 Ubuntu 20.04 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Question / suggestion: the image's tag could indicate which CUDA version was used to build the container, in addition to the pykilosort version number. See
build.sh. Just a thought.