Skip to content

temp add profile-pane overrides#527

Open
bourgeoa wants to merge 2 commits intomainfrom
newStyle
Open

temp add profile-pane overrides#527
bourgeoa wants to merge 2 commits intomainfrom
newStyle

Conversation

@bourgeoa
Copy link
Contributor

@bourgeoa bourgeoa commented Feb 4, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily updates the profile-pane dependency to a prerelease version and adds an override configuration for it. The title indicates this is a temporary change, likely for testing or development purposes.

Changes:

  • Updated profile-pane from ^3.0.0 to ^3.0.0-264c7cec (a prerelease version with commit hash)
  • Added profile-pane to the overrides section using the $profile-pane reference pattern

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
package.json Updated profile-pane dependency to prerelease version and added override entry
package-lock.json Reflected the version update with new resolved URL and integrity hash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"solid-logic": "$solid-logic",
"solid-ui": "$solid-ui"
"solid-ui": "$solid-ui",
"profile-pane": "$profile-pane"
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The override for "profile-pane" using "$profile-pane" creates a circular reference since profile-pane is in dependencies (not devDependencies). Unlike the other overrides (rdflib, solid-logic, solid-ui) which reference versions from devDependencies, this override references the same dependency version it's trying to override.

If the intent is to force all transitive dependencies to use this specific version, the override should either:

  1. Specify the exact version (e.g., "profile-pane": "^3.0.0-264c7cec"), or
  2. Move profile-pane to devDependencies following the pattern of the other overridden packages.

The current configuration may not have the intended effect.

Suggested change
"profile-pane": "$profile-pane"
"profile-pane": "^3.0.0-264c7cec"

Copilot uses AI. Check for mistakes.
"mime-types": "^3.0.2",
"pane-registry": "^3.0.1",
"profile-pane": "^3.0.0",
"profile-pane": "^3.0.0-264c7cec",
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a prerelease version (3.0.0-264c7cec) in production dependencies is concerning, especially given the PR title "temp add profile-pane overrides" which suggests this is a temporary change. Prerelease versions with commit hashes are typically used for testing and development, not for production releases.

Consider:

  1. If this is temporary for testing, ensure it's reverted before merging to production
  2. If the changes from this prerelease are needed, wait for an official stable release
  3. Document why this specific prerelease version is required if it must be used

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant