Open
Conversation
changelog.txt was renamed to changelog.md, but build.go wasn't updated accordingly. this fixes GitHub Actions.
Previously Windows artifacts were named .zip but contained tar.gz data; produce proper ZIPs now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the CI was failing because changelog.txt got renamed to changelog.md. I made a small change to the build script to fix this.
I then noticed the windows artifacts are rather confusing - they are a targz (named zip). This was throwing off extractors (windows thought it was a password-protected zip), until renamed to .tar.gz.
I fixed this, but then realized, the artifacts are all zips. With either targz or zip archives inside them.
GitHub actions seems to be unable to upload a unzipped file as an artifact, it's always a zip, with other archives inside. So either way you need a zip extractor, making its pointless to compress everything to targz.
This makes my second commit somewhat redundant, but I figured it was better to fix the confusion when archiving anyway.
I can drop the last commit if it's undesired.