Conversation
beauby
force-pushed
the
osx-support
branch
3 times, most recently
from
e986cd4 to
43baeed
Compare
jberdine
reviewed
Oct 9, 2024
Contributor
jberdine
left a comment
jberdine
left a comment
There was a problem hiding this comment.
Most of this isn't specific to macOS right? It would be better to divide into 2 PRs I think.
| modified_files = mutable Vector[]; | ||
| deleted_files = mutable Vector[]; | ||
|
|
||
| // FIXME: This is O(n^2). |
Contributor
There was a problem hiding this comment.
Are the srcs arrays already sorted? A linear traversal of new_srcs seems unavoidable. So perhaps the best that can be done is to sort old_srcs and use a binary search instead of Array.find. Maybe it would be better to also sort new_srcs and then be able to narrow the binary search of old_srcs at each step.
Contributor
Author
That's correct. The aim of this branch is to get OSX support down the line, and I made it a PR for visibility. I'll split self-contained commits out into separate PRs. |
Its `Error` superclass constructor requires an argument of type `string | undefined`, so change from `: any` to `?: string`.
In the runtime it is an `unsigned char`, so declare it as a `number` in TS.
To help code review, I have extracted a few small changes that might be functional from upcoming changes to appease the type-checker and linter. Some individual commit summaries have more info.
Add multiple resources test
Now that array proxying is gone with SkipLabs#526
(stacked on SkipLabs#519) Adds a runnable version of the getting started example and applies a handful of unrelated bug fixes and cleanups. Run as follows: ``` cd skipruntime-ts make bunbuild bun run examples/groups.ts & bun run examples/groups-server.ts & bun run examples/groups-client ```
…ipLabs#527) See second commit for payoff in client code
This endpoint previously responded with a JSON-encoded string (i.e. including quotes).
This endpoint previously responded with a JSON-encoded string (i.e. including quotes).
This is a documentation only thing.
This is a documentation only thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.