[dardama] Adding tests#11
Open
megha-darda wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Open
[dardama] Adding tests#11megha-darda wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
megha-darda wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a complete testing setup for the 2D diffusion solver.
What was added:
Checks:
I tested if the test cases failed if I introduced breaking changes:
test_initialize_domain unit test and both the integration tests failed as expected
test_initialize_physical_parameters unit test and again both the integration tests failed as expected
test_set_initial_condition unit test and only the test_set_initial_condition integration test failed as expected