Add support for default max tries setting for Http requests#282
Open
ugurarici wants to merge 2 commits intoShopify:mainfrom
Open
Add support for default max tries setting for Http requests#282ugurarici wants to merge 2 commits intoShopify:mainfrom
ugurarici wants to merge 2 commits intoShopify:mainfrom
Conversation
Author
|
I have signed the CLA! |
|
@paulomarg who is the best person to review things like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #281
Shopify\Clients\Httpis able to retry a request if response code is retriable andtriesparameter given to request method. This change gives ability to set a default max tries count for each Http request unless overridden by request method parameter. This way we can also use retries with REST resources.WHAT is this pull request doing?
Adds a
$maxTriesparameter toShopify\Context::initializemethod with a default value of 1. Assigns it toShopify\Context::$MAX_TRIESand uses it as default value inrequestmethod ofShopify\Client\Http.Type of change
Checklist