Accept small differences in floating-point results between C & Go lua implementations#138
Open
detaoin wants to merge 3 commits intoShopify:mainfrom
Open
Accept small differences in floating-point results between C & Go lua implementations#138detaoin wants to merge 3 commits intoShopify:mainfrom
detaoin wants to merge 3 commits intoShopify:mainfrom
Conversation
added 3 commits
December 16, 2024 22:17
At least on Debian (and derived distributions), the luac compiler for version 5.2 is explicitly named luac5.2. Otherwise, today, version 5.4 is used instead.
It is known that the Go stdlib math functions may give different results than the C equivalents. See golang/go#25270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing the C lua compiler (binary dump) differences, the test failed
TestParserExhaustivelyinlua-tests/attrib.luawithparser_test.go:134: 153: 1.0000000000000001e+33 != 1e+33.This is caused by different implementations of
math.Powin Go, and Cpowfunctions.I also replaced calls to executable
luacwithluac5.2; at least on recent Debian and Ubuntu versions, lua version 5.2 compiler is named so. (otherwise lua 5.4 would be used today)