Avoid undefined behaviour when doing range checks for integers#107
Open
siddhesh wants to merge 1 commit intoShopify:mainfrom
siddhesh:undef-float
Open
Avoid undefined behaviour when doing range checks for integers#107siddhesh wants to merge 1 commit intoShopify:mainfrom siddhesh:undef-float
siddhesh wants to merge 1 commit intoShopify:mainfrom
siddhesh:undef-float
Conversation
Casting from floating point to integer is undefined for values that exceed the valid range of the target integer type and this results in failure of test `assert(not pcall(string.format, "%d", 2^63))` in lua-tests for aarch64. Replace with a safer test for value ranges that does not rely on the cast from float to integer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting from floating point to integer is undefined for values that
exceed the valid range of the target integer type and this results in
failure of test
assert(not pcall(string.format, "%d", 2^63))inlua-tests for aarch64.
Replace with a safer test for value ranges that does not rely on the
cast from float to integer.